Issue 2892203003: Remove IncrementalResolvedAstGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2892203003: Remove IncrementalResolvedAstGenerator. (Closed)

Created:
3 years, 7 months ago by scheglov

Modified:
3 years, 7 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Remove IncrementalResolvedAstGenerator. It is not used anymore, and there is a compilation errors accidentally introduced. So, I guess it is easier to remove it than to fix it. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/658ff7ba99381f70f739f9a4e0d1de7286f6c1a0

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -574 lines)			Patch
D	pkg/front_end/lib/incremental_resolved_ast_generator.dart	View	1 chunk	+0 lines, -98 lines	0 comments	Download
M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart	View	1 chunk	+0 lines, -303 lines	0 comments	Download
D	pkg/front_end/test/incremental_resolved_ast_generator_test.dart	View	1 chunk	+0 lines, -172 lines	0 comments	Download

Total messages: 4 (1 generated)

Siggi Cherem (dart-lang)

lgtm, thanks! I agree, we should delete it for now.

3 years, 7 months ago (2017-05-19 21:58:46 UTC) #2

scheglov

3 years, 7 months ago (2017-05-19 22:07:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
658ff7ba99381f70f739f9a4e0d1de7286f6c1a0 (presubmit successful).