Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: ios/web_view/test/chrome_web_view_kvo_inttest.mm

Issue 2892193002: Add unittest to test CWVWebView. (Closed)
Patch Set: Respond to comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/test/chrome_web_view_kvo_inttest.mm
diff --git a/ios/web_view/test/chrome_web_view_kvo_inttest.mm b/ios/web_view/test/chrome_web_view_kvo_inttest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..30e5131b3c19f0dfad2083f0734a3bbfd65a3ea1
--- /dev/null
+++ b/ios/web_view/test/chrome_web_view_kvo_inttest.mm
@@ -0,0 +1,94 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <ChromeWebView/ChromeWebView.h>
+#import <Foundation/Foundation.h>
+
+#import "base/mac/scoped_nsobject.h"
+#import "ios/web_view/test/boolean_observer.h"
+#import "ios/web_view/test/chrome_web_view_test.h"
+#import "ios/web_view/test/web_view_interaction_test_util.h"
+#import "net/base/mac/url_conversions.h"
+#include "testing/gtest_mac.h"
+#include "url/gurl.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+class ChromeWebViewKvoTest : public ios_web_view::ChromeWebViewTest {
+ protected:
+ ChromeWebViewKvoTest() {
+ CWVWebViewConfiguration* configuration =
+ [CWVWebViewConfiguration defaultConfiguration];
+ web_view_.reset([[CWVWebView alloc]
+ initWithFrame:CGRectMake(0.0, 0.0, 100.0, 100.0)
+ configuration:configuration]);
+ }
+
+ // Web View used to listen for expected KVO property changes.
+ base::scoped_nsobject<CWVWebView> web_view_;
+};
+
+namespace ios_web_view {
+
+// Test CWVWebView correctly reports |canGoBack| and |canGoForward| state.
Eugene But (OOO till 7-30) 2017/05/23 19:49:33 s/Test/Tests that ?
michaeldo 2017/05/24 15:02:35 Done.
+TEST_F(ChromeWebViewKvoTest, CanGoBackForward) {
+ BooleanObserver* back_observer = [[BooleanObserver alloc] init];
+ [back_observer setObservedObject:web_view_ keyPath:@"canGoBack"];
+
+ BooleanObserver* forward_observer = [[BooleanObserver alloc] init];
+ [forward_observer setObservedObject:web_view_ keyPath:@"canGoForward"];
+
+ ASSERT_FALSE(back_observer.lastValue);
+ ASSERT_FALSE(forward_observer.lastValue);
+
+ // Define pages in reverse order so the links can reference the "next" page.
+ GURL page_3 = GetURLForPageWithTitle("Page 3");
Eugene But (OOO till 7-30) 2017/05/23 19:49:33 nit: page_3_url ?
michaeldo 2017/05/24 15:02:35 Done.
+
+ std::string page_2_html =
+ "<a id='link_2' href='" + page_3.spec() + "'>Link 2</a>";
+ GURL page_2 = GetURLForPageWithHTMLBody(page_2_html);
+
+ std::string page_1_html =
+ "<a id='link_1' href='" + page_2.spec() + "'>Link 1</a>";
+ GURL page_1 = GetURLForPageWithHTMLBody(page_1_html);
+
+ LoadURL(web_view_, net::NSURLWithGURL(page_1));
+ // Loading initial URL should not affect back/forward navigation state.
+ EXPECT_FALSE(back_observer.lastValue);
+ EXPECT_FALSE(forward_observer.lastValue);
+
+ // Navigate to page 2.
+ EXPECT_TRUE(test::TapChromeWebViewElementWithId(web_view_, @"link_1"));
+ WaitForPageLoadCompletion(web_view_);
+ EXPECT_TRUE(back_observer.lastValue);
+ EXPECT_FALSE(forward_observer.lastValue);
+
+ // Navigate back to page 1.
+ [web_view_ goBack];
+ WaitForPageLoadCompletion(web_view_);
+ EXPECT_FALSE(back_observer.lastValue);
+ EXPECT_TRUE(forward_observer.lastValue);
+
+ // Navigate forward to page 2.
+ [web_view_ goForward];
+ WaitForPageLoadCompletion(web_view_);
+ EXPECT_TRUE(back_observer.lastValue);
+ EXPECT_FALSE(forward_observer.lastValue);
+
+ // Navigate to page 3.
+ EXPECT_TRUE(test::TapChromeWebViewElementWithId(web_view_, @"link_2"));
+ WaitForPageLoadCompletion(web_view_);
+ EXPECT_TRUE(back_observer.lastValue);
+ EXPECT_FALSE(forward_observer.lastValue);
+
+ // Navigate back to page 2.
+ [web_view_ goBack];
+ WaitForPageLoadCompletion(web_view_);
+ EXPECT_TRUE(back_observer.lastValue);
+ EXPECT_TRUE(forward_observer.lastValue);
+}
+
+} // namespace ios_web_view

Powered by Google App Engine
This is Rietveld 408576698