Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: media/video/video_decode_accelerator.h

Issue 2892083002: Send enter / exit fullscreen signal to AVDA (Closed)
Patch Set: rebased. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/ipc/service/gpu_video_decode_accelerator.cc ('k') | media/video/video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/video/video_decode_accelerator.h
diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index e61f6e2777f2976bf0dd27cc67d74596c0923432..b37a85e3af39c05c0e99cae8a597caa59945a263 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -17,6 +17,7 @@
#include "media/base/bitstream_buffer.h"
#include "media/base/cdm_context.h"
#include "media/base/encryption_scheme.h"
+#include "media/base/overlay_info.h"
#include "media/base/surface_manager.h"
#include "media/base/video_decoder_config.h"
#include "media/video/picture.h"
@@ -150,14 +151,9 @@ class MEDIA_EXPORT VideoDecodeAccelerator {
// Whether the client supports deferred initialization.
bool is_deferred_initialization_allowed = false;
- // An optional graphics surface that the VDA should render to. For setting
- // an output SurfaceView on Android. It's only valid when not equal to
- // |kNoSurfaceID|.
- // TODO(liberato): should this be Optional<> instead?
- int surface_id = SurfaceManager::kNoSurfaceID;
-
- // An optional routing token for AndroidOverlay.
- base::Optional<base::UnguessableToken> overlay_routing_token;
+ // Optional overlay info available at startup, rather than waiting for the
+ // VDA to receive a callback.
+ OverlayInfo overlay_info;
// Coded size of the video frame hint, subject to change.
gfx::Size initial_expected_coded_size = gfx::Size(320, 240);
@@ -313,9 +309,7 @@ class MEDIA_EXPORT VideoDecodeAccelerator {
// previously set surface in favor of an internally generated texture.
// |routing_token| is an optional AndroidOverlay routing token. At most one
// should be non-empty.
- virtual void SetSurface(
- int32_t surface_id,
- const base::Optional<base::UnguessableToken>& routing_token);
+ virtual void SetOverlayInfo(const OverlayInfo& overlay_info);
// Destroys the decoder: all pending inputs are dropped immediately and the
// component is freed. This call may asynchornously free system resources,
« no previous file with comments | « media/gpu/ipc/service/gpu_video_decode_accelerator.cc ('k') | media/video/video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698