Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java

Issue 2892043002: Handle File.listFiles() returning null on IO errors (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
index 79ef3a334bb661d51960348702b5927b4ee1a11c..b0d81564b2f7e9807e1603931c6c6f7e6ebc9307 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
@@ -119,7 +119,10 @@ public class ShareHelper {
private static void deleteShareImageFiles(File file) {
if (!file.exists()) return;
if (file.isDirectory()) {
- for (File f : file.listFiles()) deleteShareImageFiles(f);
+ File[] file_list = file.listFiles();
+ if (file_list != null) {
+ for (File f : file_list) deleteShareImageFiles(f);
+ }
}
if (!file.delete()) {
Log.w(TAG, "Failed to delete share image file: %s", file.getAbsolutePath());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698