third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html - Issue 2892033002: Enable support for draft-ietf-webpush-encryption-08

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html

Issue 2892033002: Enable support for draft-ietf-webpush-encryption-08 (Closed)

Patch Set: Enable support for draft-ietf-webpush-encryption-08 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc ('K') | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | third_party/WebKit/Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html b/third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html

index 27fcc9e66422cef8365fa626afcc2d80b2ebfe65..9f81a0f3844d04feca32e4e7b86022b5202e4f93 100644

--- a/third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html

+++ b/third_party/WebKit/LayoutTests/http/tests/push_messaging/pushmanager-supported-content-encodings.html

@@ -17,9 +17,9 @@

assert_equals(PushManager.supportedContentEncodings, PushManager.supportedContentEncodings);

assert_true(Array.isArray(PushManager.supportedContentEncodings));

- // TODO(crbug.com/679789): The `aes128gcm` Content-Encoding must be supported as well.

- assert_equals(PushManager.supportedContentEncodings.length, 1);

- assert_equals(PushManager.supportedContentEncodings[0], 'aesgcm');

+ assert_equals(PushManager.supportedContentEncodings.length, 2);

+ assert_equals(PushManager.supportedContentEncodings[0], 'aes128gcm');

johnme 2017/05/23 17:37:48 Nit: do we care about the order? If not, could use

+ assert_equals(PushManager.supportedContentEncodings[1], 'aesgcm');

});

</script>

</body>