Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

Issue 2892013002: [Cronet] Clean up tests (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
index d8748489256a036ad1b9353c9b01c16894f14098..061947e85b06185acc1d2a1597ffc79416984ac4 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
@@ -9,8 +9,8 @@ import android.support.test.filters.SmallTest;
import org.json.JSONObject;
import org.chromium.base.test.util.Feature;
+import org.chromium.net.CronetEngine;
import org.chromium.net.CronetTestBase;
-import org.chromium.net.CronetTestFramework;
import org.chromium.net.CronetTestUtil;
import org.chromium.net.ExperimentalCronetEngine;
import org.chromium.net.QuicTestServer;
@@ -25,7 +25,7 @@ import java.util.Arrays;
*/
@SuppressWarnings("deprecation")
public class QuicUploadTest extends CronetTestBase {
- private CronetTestFramework mTestFramework;
+ private CronetEngine mCronetEngine;
@Override
protected void setUp() throws Exception {
@@ -49,7 +49,7 @@ public class QuicUploadTest extends CronetTestBase {
CronetTestUtil.setMockCertVerifierForTesting(
builder, QuicTestServer.createMockCertVerifier());
- mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+ mCronetEngine = builder.build();
}
@SmallTest
@@ -59,8 +59,7 @@ public class QuicUploadTest extends CronetTestBase {
public void testOneMassiveWrite() throws Exception {
String path = "/simple.txt";
URL url = new URL(QuicTestServer.getServerURL() + path);
- HttpURLConnection connection =
- (HttpURLConnection) mTestFramework.mCronetEngine.openConnection(url);
+ HttpURLConnection connection = (HttpURLConnection) mCronetEngine.openConnection(url);
connection.setDoOutput(true);
connection.setRequestMethod("POST");
// Size is chosen so the last time mBuffer will be written 14831 bytes,

Powered by Google App Engine
This is Rietveld 408576698