Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 2892013002: [Cronet] Clean up tests (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index a60d1509861ddf10db9cc773df902325927d8860..da751331aef22815f7003c5396b4f4c3a5d661fe 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -12,7 +12,6 @@ import org.chromium.base.test.util.Feature;
import org.chromium.net.CronetEngine;
import org.chromium.net.CronetException;
import org.chromium.net.CronetTestBase;
-import org.chromium.net.CronetTestFramework;
import org.chromium.net.MockUrlRequestJobFactory;
import org.chromium.net.NativeTestServer;
@@ -47,13 +46,8 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
@Override
protected void setUp() throws Exception {
super.setUp();
- String[] commandLineArgs = {
- CronetTestFramework.CACHE_KEY, CronetTestFramework.CACHE_DISK,
- CronetTestFramework.LIBRARY_INIT_KEY,
- CronetTestFramework.LibraryInitType.HTTP_URL_CONNECTION,
- };
- mCronetEngine = startCronetTestFrameworkWithUrlAndCommandLineArgs(null,
- commandLineArgs).mCronetEngine;
+ mCronetEngine = enableDiskCache(new CronetEngine.Builder(getContext())).build();
+ setStreamHandlerFactory(mCronetEngine);
assertTrue(NativeTestServer.startNativeTestServer(getContext()));
}

Powered by Google App Engine
This is Rietveld 408576698