[Cronet] Clean up tests

components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import static org.chromium.base.CollectionUtil.newHashSet;
 
 import android.support.test.filters.SmallTest;
 
 import org.json.JSONObject;
 
 import org.chromium.base.test.util.Feature;
 import org.chromium.net.MetricsTestUtil.TestRequestFinishedListener;
 
 import java.nio.ByteBuffer;
 import java.util.Date;
 import java.util.HashSet;
 
 /**
  * Tests functionality of BidirectionalStream's QUIC implementation.
  */
 public class BidirectionalStreamQuicTest extends CronetTestBase {
-    private CronetTestFramework mTestFramework;
+    private ExperimentalCronetEngine mCronetEngine;
     private enum QuicBidirectionalStreams {
         ENABLED,
         DISABLED,
     }
 
     private void setUp(QuicBidirectionalStreams enabled) throws Exception {
         // Load library first to create MockCertVerifier.
         System.loadLibrary("cronet_tests");
         ExperimentalCronetEngine.Builder builder =
                 new ExperimentalCronetEngine.Builder(getContext());
@@ skipping 10 matching lines @@
                                                  .put("QUIC", quicParams)
                                                  .put("HostResolverRules", hostResolverParams);
         builder.setExperimentalOptions(experimentalOptions.toString());
 
         builder.addQuicHint(QuicTestServer.getServerHost(), QuicTestServer.getServerPort(),
                 QuicTestServer.getServerPort());
 
         CronetTestUtil.setMockCertVerifierForTesting(
                 builder, QuicTestServer.createMockCertVerifier());
 
-        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+        mCronetEngine = builder.build();
     }
 
     @Override
     protected void tearDown() throws Exception {
         QuicTestServer.shutdownQuicTestServer();
         super.tearDown();
     }
 
     @SmallTest
     @Feature({"Cronet"})
     @OnlyRunNativeCronet
     // Test that QUIC is negotiated.
     public void testSimpleGet() throws Exception {
         setUp(QuicBidirectionalStreams.ENABLED);
         String path = "/simple.txt";
         String quicURL = QuicTestServer.getServerURL() + path;
         TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
         BidirectionalStream stream =
-                mTestFramework.mCronetEngine
+                mCronetEngine
                         .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
                         .setHttpMethod("GET")
                         .build();
         stream.start();
         callback.blockForDone();
         assertTrue(stream.isDone());
         assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
         assertEquals("This is a simple text file served by QUIC.\n", callback.mResponseAsString);
         assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
     }
 
     @SmallTest
     @Feature({"Cronet"})
     @OnlyRunNativeCronet
     public void testSimplePost() throws Exception {
         setUp(QuicBidirectionalStreams.ENABLED);
         String path = "/simple.txt";
         String quicURL = QuicTestServer.getServerURL() + path;
         TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
         // Although we have no way to verify data sent at this point, this test
         // can make sure that onWriteCompleted is invoked appropriately.
         callback.addWriteData("Test String".getBytes());
         callback.addWriteData("1234567890".getBytes());
         callback.addWriteData("woot!".getBytes());
         TestRequestFinishedListener requestFinishedListener = new TestRequestFinishedListener();
-        mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
+        mCronetEngine.addRequestFinishedListener(requestFinishedListener);
         BidirectionalStream stream =
-                mTestFramework.mCronetEngine
+                mCronetEngine
                         .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
                         .addHeader("foo", "bar")
                         .addHeader("empty", "")
                         .addHeader("Content-Type", "zebra")
                         .addRequestAnnotation("request annotation")
                         .addRequestAnnotation(this)
                         .build();
         Date startTime = new Date();
         stream.start();
         callback.blockForDone();
@@ skipping 19 matching lines @@
         // TODO(xunjieli): Use ParameterizedTest instead of the loop.
         for (int i = 0; i < 2; i++) {
             String path = "/simple.txt";
             String quicURL = QuicTestServer.getServerURL() + path;
             TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
             // Although we have no way to verify data sent at this point, this test
             // can make sure that onWriteCompleted is invoked appropriately.
             callback.addWriteData("Test String".getBytes(), false);
             callback.addWriteData("1234567890".getBytes(), false);
             callback.addWriteData("woot!".getBytes(), true);
-            BidirectionalStream stream = mTestFramework.mCronetEngine
+            BidirectionalStream stream = mCronetEngine
                                                  .newBidirectionalStreamBuilder(
                                                          quicURL, callback, callback.getExecutor())
                                                  .delayRequestHeadersUntilFirstFlush(i == 0)
                                                  .addHeader("foo", "bar")
                                                  .addHeader("empty", "")
                                                  .addHeader("Content-Type", "zebra")
                                                  .build();
             stream.start();
             callback.blockForDone();
             assertTrue(stream.isDone());
@@ skipping 15 matching lines @@
             String quicURL = QuicTestServer.getServerURL() + path;
             TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
             // Although we have no way to verify data sent at this point, this test
             // can make sure that onWriteCompleted is invoked appropriately.
             callback.addWriteData("Test String".getBytes(), false);
             callback.addWriteData("1234567890".getBytes(), false);
             callback.addWriteData("woot!".getBytes(), true);
             callback.addWriteData("Test String".getBytes(), false);
             callback.addWriteData("1234567890".getBytes(), false);
             callback.addWriteData("woot!".getBytes(), true);
-            BidirectionalStream stream = mTestFramework.mCronetEngine
+            BidirectionalStream stream = mCronetEngine
                                                  .newBidirectionalStreamBuilder(
                                                          quicURL, callback, callback.getExecutor())
                                                  .delayRequestHeadersUntilFirstFlush(i == 0)
                                                  .addHeader("foo", "bar")
                                                  .addHeader("empty", "")
                                                  .addHeader("Content-Type", "zebra")
                                                  .build();
             stream.start();
             callback.blockForDone();
             assertTrue(stream.isDone());
@@ skipping 16 matching lines @@
 
             TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback() {
                 @Override
                 public void onStreamReady(BidirectionalStream stream) {
                     // This flush should send the delayed headers.
                     stream.flush();
                     super.onStreamReady(stream);
                 }
             };
             BidirectionalStream stream =
-                    mTestFramework.mCronetEngine
+                    mCronetEngine
                             .newBidirectionalStreamBuilder(url, callback, callback.getExecutor())
                             .setHttpMethod("GET")
                             .delayRequestHeadersUntilFirstFlush(i == 0)
                             .addHeader("foo", "bar")
                             .addHeader("empty", "")
                             .build();
             // Flush before stream is started should not crash.
             stream.flush();
 
             stream.start();
@@ skipping 17 matching lines @@
     public void testSimplePostWithFlushAfterOneWrite() throws Exception {
         setUp(QuicBidirectionalStreams.ENABLED);
         // TODO(xunjieli): Use ParameterizedTest instead of the loop.
         for (int i = 0; i < 2; i++) {
             String path = "/simple.txt";
             String url = QuicTestServer.getServerURL() + path;
 
             TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
             callback.addWriteData("Test String".getBytes(), true);
             BidirectionalStream stream =
-                    mTestFramework.mCronetEngine
+                    mCronetEngine
                             .newBidirectionalStreamBuilder(url, callback, callback.getExecutor())
                             .delayRequestHeadersUntilFirstFlush(i == 0)
                             .addHeader("foo", "bar")
                             .addHeader("empty", "")
                             .addHeader("Content-Type", "zebra")
                             .build();
             stream.start();
             callback.blockForDone();
             assertTrue(stream.isDone());
 
             assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
             assertEquals(
                     "This is a simple text file served by QUIC.\n", callback.mResponseAsString);
             assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
         }
     }
 
     @SmallTest
     @Feature({"Cronet"})
     @OnlyRunNativeCronet
     public void testQuicBidirectionalStreamDisabled() throws Exception {
         setUp(QuicBidirectionalStreams.DISABLED);
         String path = "/simple.txt";
         String quicURL = QuicTestServer.getServerURL() + path;
 
         TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
         BidirectionalStream stream =
-                mTestFramework.mCronetEngine
+                mCronetEngine
                         .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
                         .setHttpMethod("GET")
                         .build();
         stream.start();
         callback.blockForDone();
         assertTrue(stream.isDone());
         assertTrue(callback.mOnErrorCalled);
         assertNull(callback.mResponseInfo);
     }
 
@@ skipping 19 matching lines @@
                 // The second call to shutdownQuicTestServer is no-op.
                 QuicTestServer.shutdownQuicTestServer();
             }
         };
 
         callback.addWriteData("Test String".getBytes());
         callback.addWriteData("1234567890".getBytes());
         callback.addWriteData("woot!".getBytes());
 
         BidirectionalStream stream =
-                mTestFramework.mCronetEngine
+                mCronetEngine
                         .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
                         .addHeader("foo", "bar")
                         .addHeader("empty", "")
                         .addHeader("Content-Type", "zebra")
                         .build();
         stream.start();
         callback.blockForDone();
         assertTrue(stream.isDone());
         // Server terminated on us, so the stream must fail.
         // QUIC reports this as ERR_QUIC_PROTOCOL_ERROR. Sometimes we get ERR_CONNECTION_REFUSED.
         assertNotNull(callback.mError);
         assertTrue(callback.mError instanceof NetworkException);
         NetworkException networkError = (NetworkException) callback.mError;
         assertTrue(NetError.ERR_QUIC_PROTOCOL_ERROR == networkError.getCronetInternalErrorCode()
                 || NetError.ERR_CONNECTION_REFUSED == networkError.getCronetInternalErrorCode());
     }
 
     @SmallTest
     @Feature({"Cronet"})
     @OnlyRunNativeCronet
     // Test that certificate verify results are serialized and deserialized correctly.
     public void testSerializeDeserialize() throws Exception {
         setUp(QuicBidirectionalStreams.ENABLED);
         String path = "/simple.txt";
         String quicURL = QuicTestServer.getServerURL() + path;
         TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
         BidirectionalStream stream =
-                mTestFramework.mCronetEngine
+                mCronetEngine
                         .newBidirectionalStreamBuilder(quicURL, callback, callback.getExecutor())
                         .setHttpMethod("GET")
                         .build();
         stream.start();
         callback.blockForDone();
         assertTrue(stream.isDone());
         assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
         assertEquals("This is a simple text file served by QUIC.\n", callback.mResponseAsString);
         assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtocol());
 
-        String serialized_data = mTestFramework.mCronetEngine.getCertVerifierData(100);
+        String serialized_data = mCronetEngine.getCertVerifierData(100);
         assertFalse(serialized_data.isEmpty());
 
         // Create a new builder and verify that the |serialized_data| is deserialized correctly.
         ExperimentalCronetEngine.Builder builder =
                 new ExperimentalCronetEngine.Builder(getContext());
         builder.enableQuic(true);
         CronetTestUtil.setMockCertVerifierForTesting(
                 builder, QuicTestServer.createMockCertVerifier());
         builder.setCertVerifierData(serialized_data);
 
-        CronetTestFramework testFramework =
-                startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
-        String deserialized_data = testFramework.mCronetEngine.getCertVerifierData(100);
+        String deserialized_data = builder.build().getCertVerifierData(100);
         assertEquals(deserialized_data, serialized_data);
     }
 }