Fix white flash when opening incognito NTP

chrome/browser/themes/theme_properties.cc

Index: chrome/browser/themes/theme_properties.cc
diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc
index e1d3c854b17af837a84c3592b70d52fa2102c5fa..ea03e3f3a37c72411ff67d71225aacc3f94a58f7 100644
--- a/chrome/browser/themes/theme_properties.cc
+++ b/chrome/browser/themes/theme_properties.cc
@@ -67,6 +67,7 @@ constexpr SkColor kDefaultColorNTPBackground = SK_ColorWHITE;
 constexpr SkColor kDefaultColorNTPText = SK_ColorBLACK;
 const SkColor kDefaultColorNTPLink = SkColorSetRGB(0x06, 0x37, 0x74);
 #endif  // OS_WIN
+const SkColor kDefaultColorNTPBackgroundOtr = SkColorSetRGB(0x30, 0x30, 0x30);

[Evan Stade, 2017/05/19 15:34:54]

nit: the term used for the colors in this file is incognito rather than otr. I
think whatever references to otr do exist are supposed to be changed.

[Marc Treib, 2017/05/19 17:13:42]

I was being consistent with the "bool otr" below ;)

Since I'm OOO now and can't change it right now, I'll land this as-is to get the
fix into M60. I solemnly promise to send a followup to fix the naming once I'm
back in ~two weeks. :)

 
 const SkColor kDefaultColorNTPHeader = SkColorSetRGB(0x96, 0x96, 0x96);
 constexpr SkColor kDefaultColorButtonBackground = SK_ColorTRANSPARENT;
@@ -235,7 +236,7 @@ SkColor ThemeProperties::GetDefaultColor(int id, bool otr) {
       return otr ? kDefaultColorBackgroundTabTextIncognito
                  : kDefaultColorBackgroundTabText;
     case COLOR_NTP_BACKGROUND:
-      return kDefaultColorNTPBackground;
+      return otr ? kDefaultColorNTPBackgroundOtr : kDefaultColorNTPBackground;
     case COLOR_NTP_TEXT:
       return kDefaultColorNTPText;
     case COLOR_NTP_LINK: