Make AudioDebugFileWriter::AudioFileWriter use a SequencedTaskRunner

media/audio/audio_debug_file_writer.h

Index: media/audio/audio_debug_file_writer.h
diff --git a/media/audio/audio_debug_file_writer.h b/media/audio/audio_debug_file_writer.h
index 9d8a4c0f9b940e5076520c1a0d1ebf43a7916924..94ed0e5d85afaca635962f41cf83e57752f82550 100644
--- a/media/audio/audio_debug_file_writer.h
+++ b/media/audio/audio_debug_file_writer.h
@@ -65,20 +65,20 @@ class MEDIA_EXPORT AudioDebugFileWriter {
   class AudioFileWriter;
 
   // Deleter for AudioFileWriter.
-  struct OnThreadDeleter {
+  struct OnSequenceDeleter {
    public:
-    OnThreadDeleter();
-    OnThreadDeleter(const OnThreadDeleter& other);
-    OnThreadDeleter(scoped_refptr<base::SingleThreadTaskRunner> task_runner);
-    ~OnThreadDeleter();
+    OnSequenceDeleter();
+    OnSequenceDeleter(const OnSequenceDeleter& other);

[gab, 2017/05/18 20:38:17]

I'm pretty sure this is only needed to pass it by value in std::unique_ptr which
should support move-semantics as of C++11.

A nice cleanup would be to make this

OnSequenceDeleter(OnSequenceDeleter&& other) = default;

and remove the impl.

[Sébastien Marchand, 2017/05/18 21:24:25]

Done, I also had to provide the OnSequenceDeleter& operator=(const
OnSequenceDeleter&) function (which is normally deleted).

+    OnSequenceDeleter(scoped_refptr<base::SequencedTaskRunner> task_runner);
+    ~OnSequenceDeleter();
     void operator()(AudioFileWriter* ptr) const;
 
    private:
-    scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+    scoped_refptr<base::SequencedTaskRunner> task_runner_;
   };
 
   using AudioFileWriterUniquePtr =
-      std::unique_ptr<AudioFileWriter, OnThreadDeleter>;
+      std::unique_ptr<AudioFileWriter, OnSequenceDeleter>;
 
   AudioFileWriterUniquePtr file_writer_;
   base::SequenceChecker client_sequence_checker_;