Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc

Issue 2891933002: UserPolicyManagerFactoryChromeOS: Elaborate comment (Closed)
Patch Set: Revert CHECK() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.h" 5 #include "chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 return {}; 171 return {};
172 } 172 }
173 173
174 policy::BrowserPolicyConnectorChromeOS* connector = 174 policy::BrowserPolicyConnectorChromeOS* connector =
175 g_browser_process->platform_part()->browser_policy_connector_chromeos(); 175 g_browser_process->platform_part()->browser_policy_connector_chromeos();
176 bool is_active_directory = false; 176 bool is_active_directory = false;
177 switch (account_id.GetAccountType()) { 177 switch (account_id.GetAccountType()) {
178 case AccountType::UNKNOWN: 178 case AccountType::UNKNOWN:
179 case AccountType::GOOGLE: 179 case AccountType::GOOGLE:
180 // TODO(tnagel): Return nullptr for unknown accounts once AccountId 180 // TODO(tnagel): Return nullptr for unknown accounts once AccountId
181 // migration is finished. 181 // migration is finished. (KioskAppManager still needs to be migrated.)
182 if (!user->HasGaiaAccount()) { 182 if (!user->HasGaiaAccount()) {
183 return {}; 183 return {};
184 } 184 }
185 is_active_directory = false; 185 is_active_directory = false;
186 break; 186 break;
187 case AccountType::ACTIVE_DIRECTORY: 187 case AccountType::ACTIVE_DIRECTORY:
188 // Active Directory users only exist on devices whose install attributes 188 // Active Directory users only exist on devices whose install attributes
189 // are locked into Active Directory mode. 189 // are locked into Active Directory mode.
190 CHECK(connector->GetInstallAttributes()->IsActiveDirectoryManaged()); 190 CHECK(connector->GetInstallAttributes()->IsActiveDirectoryManaged());
191 is_active_directory = true; 191 is_active_directory = true;
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 321
322 bool UserPolicyManagerFactoryChromeOS::HasTestingFactory( 322 bool UserPolicyManagerFactoryChromeOS::HasTestingFactory(
323 content::BrowserContext* context) { 323 content::BrowserContext* context) {
324 return false; 324 return false;
325 } 325 }
326 326
327 void UserPolicyManagerFactoryChromeOS::CreateServiceNow( 327 void UserPolicyManagerFactoryChromeOS::CreateServiceNow(
328 content::BrowserContext* context) {} 328 content::BrowserContext* context) {}
329 329
330 } // namespace policy 330 } // namespace policy
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698