extensions/browser/api/cast_channel/BUILD.gn - Issue 2891923004: [cast_channel] Make cast_channel related files not depend on "cast_channel.h"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/BUILD.gn

Issue 2891923004: [cast_channel] Make cast_channel related files not depend on "cast_channel.h" (Closed)

Patch Set: resolve code review comments from Mark Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/BUILD.gn

diff --git a/extensions/browser/api/cast_channel/BUILD.gn b/extensions/browser/api/cast_channel/BUILD.gn

index 119ef06a5df35a61836139a104296ce13f937930..cb80dc64e50365df4b604cf6afe4894528079fcb 100644

--- a/extensions/browser/api/cast_channel/BUILD.gn

+++ b/extensions/browser/api/cast_channel/BUILD.gn

@@ -8,6 +8,8 @@ source_set("cast_channel") {

"cast_auth_util.h",

"cast_channel_api.cc",

"cast_channel_api.h",

+ "cast_channel_type_util.cc",

+ "cast_channel_type_util.h",

"cast_framer.cc",

"cast_framer.h",

"cast_message_util.cc",

@@ -24,6 +26,7 @@ source_set("cast_channel") {

deps = [

"//base",

+ "//components/cast_channel",

"//extensions/common/api",

"//extensions/common/api/cast_channel:cast_channel_proto",

"//net",