Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2087)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc

Issue 2891823002: Linux native notifications: Remove spec_version check (Closed)
Patch Set: Remove kMethodGetServerInformation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
index 712eb6bf4fb9ae03396857a3453de8b941222bfa..1ff1192a533a0b7c321d3ef5dfc09345d76bd1f1 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
@@ -176,16 +176,6 @@ ACTION_P(OnGetCapabilities, capabilities) {
return response;
}
-ACTION_P(OnGetServerInformation, spec_version) {
- dbus::Response* response = dbus::Response::CreateEmpty().release();
- dbus::MessageWriter writer(response);
- writer.AppendString(""); // name
- writer.AppendString(""); // vendor
- writer.AppendString(""); // version
- writer.AppendString(spec_version);
- return response;
-}
-
ACTION_P2(OnNotify, verifier, id) {
verifier(ParseRequest(arg0));
return GetIdResponse(id);
@@ -231,10 +221,6 @@ class NotificationPlatformBridgeLinuxTest : public testing::Test {
.WillOnce(OnGetCapabilities(std::vector<std::string>{
"body", "body-hyperlinks", "body-images", "body-markup"}));
- EXPECT_CALL(*mock_notification_proxy_.get(),
- MockCallMethodAndBlock(Calls("GetServerInformation"), _))
- .WillOnce(OnGetServerInformation("1.2"));
-
EXPECT_CALL(
*mock_notification_proxy_.get(),
ConnectToSignal(kFreedesktopNotificationsName, "ActionInvoked", _, _))
« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_linux.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698