Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2891763003: [WIP, DONOTCOMMIT] Test case for multi-result spellcheck (Closed)

Created:
3 years, 7 months ago by groby-ooo-7-16
Modified:
3 years, 6 months ago
Reviewers:
rlanday
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, Xiaocheng, jam, timvolodine, blink-reviews, dglazkov+blink, rlp+watch_chromium.org, rouslan+spell_chromium.org, mac-reviews_chromium.org, groby+spellwatch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, jochen+watch_chromium.org, groby+blinkspell_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP, DONOTCOMMIT] Test case for multi-result spellcheck Original patch from issue 2848943002 at patchset 80001 (http://crrev.com/2848943002#ps80001) Mostly, this is to provide a test to illustrate a case I'm trying to make.

Patch Set 1 #

Patch Set 2 : Added testcase demonstrating failure mode #

Patch Set 3 : Proposed fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -66 lines) Patch
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/spellcheck/common/spellcheck_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/spellcheck/common/spellcheck_result.h View 2 chunks +16 lines, -6 lines 0 comments Download
A components/spellcheck/common/spellcheck_result.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/spellcheck/renderer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 1 2 3 chunks +21 lines, -9 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_provider_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/spellcheck/renderer/spellcheck_unittest.cc View 2 chunks +46 lines, -16 lines 0 comments Download
A components/spellcheck/renderer/spellcheck_unittest2.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download
M content/shell/test_runner/mock_spell_check.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/test_runner/spell_check_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 4 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextChecking.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebTextCheckingResult.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebTextCheckingResult.h View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
groby-ooo-7-16
3 years, 7 months ago (2017-05-17 22:12:17 UTC) #3
NOT LGTM

To prevent myself from accidentally hitting commit :)

Powered by Google App Engine
This is Rietveld 408576698