Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2891743002: Update the log viewer to understand the plugin entries (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the log viewer to understand the plugin entries R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d9f1c2620b7f74ebffde55d0bd90c9c37880892c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -8 lines) Patch
M pkg/analysis_server/tool/instrumentation/log/log.dart View 6 chunks +233 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/instrumentation/page/log_page.dart View 2 chunks +45 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/instrumentation/page/stats_page.dart View 9 chunks +67 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-17 13:16:12 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 14:10:53 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-17 14:51:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9f1c2620b7f74ebffde55d0bd90c9c37880892c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698