runtime/vm/flow_graph_type_propagator.cc - Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)

Patch Set: Feedback from Martin Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index a11c33b700374a3c391fb7969896338c0de287b0..4b348882ffb20577da637e221f0335e547d03872 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -249,8 +249,8 @@ void FlowGraphTypePropagator::VisitCheckClassId(CheckClassIdInstr* check) {

LoadClassIdInstr* load_cid =

check->value()->definition()->OriginalDefinition()->AsLoadClassId();

- if (load_cid != NULL) {

- SetCid(load_cid->object()->definition(), check->cid());

+ if (load_cid != NULL && check->cids().IsSingleCid()) {

+ SetCid(load_cid->object()->definition(), check->cids().cid_start);

}

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »