media/midi/midi_manager_android.h - Issue 2891683002: Remove ScopedVector from all other codes in media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager_android.h

Issue 2891683002: Remove ScopedVector from all other codes in media/ (Closed)

Patch Set: Address alokp and xhwang's comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/midi/midi_manager_android.h

diff --git a/media/midi/midi_manager_android.h b/media/midi/midi_manager_android.h

index fa29a441dbbf6adde817b34b14fa4193869ef17c..467afae5a2d1e153d584b6cecceb484d7a42ddf6 100644

--- a/media/midi/midi_manager_android.h

+++ b/media/midi/midi_manager_android.h

@@ -14,7 +14,6 @@

#include "base/android/scoped_java_ref.h"

#include "base/containers/hash_tables.h"

-#include "base/memory/scoped_vector.h"

#include "base/synchronization/lock.h"

#include "base/time/time.h"

#include "media/midi/midi_input_port_android.h"

@@ -72,7 +71,7 @@ class MidiManagerAndroid final : public MidiManager,

void AddOutputPortAndroid(MidiOutputPortAndroid* port,

MidiDeviceAndroid* device);

- ScopedVector<MidiDeviceAndroid> devices_;

+ std::vector<std::unique_ptr<MidiDeviceAndroid>> devices_;

// All ports held in |devices_|. Each device has ownership of ports, but we

// can store pointers here because a device will keep its ports while it is

// alive.

« no previous file with comments | « media/midi/midi_device_android.cc ('k') | media/midi/midi_manager_android.cc » ('j') | no next file with comments »