Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3338)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)
Patch Set: Fixed range on Cocoa Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 6add5dda5be118436629c2afa3534209146d6c72..521eeee2e875a990dd622af1aadbb7b5029ce81e 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -429,6 +429,10 @@ void OmniboxViewViews::SetWindowTextAndCaretPos(const base::string16& text,
TextChanged();
}
+void OmniboxViewViews::SetCaretPos(size_t caret_pos) {
+ SelectRange(gfx::Range(caret_pos, caret_pos));
+}
+
bool OmniboxViewViews::IsSelectAll() const {
// TODO(oshima): IME support.
return text() == GetSelectedText();
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.h ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698