Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5965)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)
Patch Set: Fixed range on Cocoa Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
index d692fc07277bf42f6d1d2a65aefd257f615de183..de3d666812823c1a0c0ee7d313fd739d6750cb50 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
@@ -353,6 +353,11 @@ void OmniboxViewMac::SetWindowTextAndCaretPos(const base::string16& text,
TextChanged();
}
+void OmniboxViewMac::SetCaretPos(size_t caret_pos) {
+ size_t pos = std::min(caret_pos, GetTextLength());
+ SetSelectedRange(NSMakeRange(pos, 0));
+}
+
void OmniboxViewMac::EnterKeywordModeForDefaultSearchProvider() {
// We need to do this first, else |SetSelectedRange()| won't work.
FocusLocation(true);
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698