[omnibox] Break out SetCaretPos() method and enhance browser test

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 411 matching lines @@
   const gfx::Range range(caret_pos, caret_pos);
   SetTextAndSelectedRange(text, range);
 
   if (update_popup)
     UpdatePopup();
 
   if (notify_text_changed)
     TextChanged();
 }
 
+void OmniboxViewViews::SetCaretPos(size_t caret_pos) {
+  size_t pos = std::min(caret_pos, text().length());

[Peter Kasting, 2017/05/18 18:38:34]

Nit: Is this actually necessary, or will SelectRange() do this for you?

[Kevin Bailey, 2017/05/18 19:48:17]

It's not necessary. It's corrected way down in RenderText. (Unlike Mac's
SetSelectedRange() which demands a valid position.)

+  const gfx::Range range(pos, pos);
+  SelectRange(range);

[Peter Kasting, 2017/05/18 18:38:34]

Nit: Or just

  SelectRange(gfx::Range(pos, pos));

[Kevin Bailey, 2017/05/18 19:48:17]

Done.

+}
+
 bool OmniboxViewViews::IsSelectAll() const {
   // TODO(oshima): IME support.
   return text() == GetSelectedText();
 }
 
 bool OmniboxViewViews::DeleteAtEndPressed() {
   return delete_at_end_pressed_;
 }
 
 void OmniboxViewViews::UpdatePopup() {
@@ skipping 625 matching lines @@
       paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
 
   menu_contents->AddSeparator(ui::NORMAL_SEPARATOR);
 
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 }