Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)
Patch Set: Fixed range on Cocoa Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 bool HandleEarlyTabActions(const ui::KeyEvent& event); 127 bool HandleEarlyTabActions(const ui::KeyEvent& event);
128 128
129 // Updates |security_level_| based on the toolbar model's current value. 129 // Updates |security_level_| based on the toolbar model's current value.
130 void UpdateSecurityLevel(); 130 void UpdateSecurityLevel();
131 131
132 // OmniboxView: 132 // OmniboxView:
133 void SetWindowTextAndCaretPos(const base::string16& text, 133 void SetWindowTextAndCaretPos(const base::string16& text,
134 size_t caret_pos, 134 size_t caret_pos,
135 bool update_popup, 135 bool update_popup,
136 bool notify_text_changed) override; 136 bool notify_text_changed) override;
137 void SetCaretPos(size_t caret_pos) override;
137 bool IsSelectAll() const override; 138 bool IsSelectAll() const override;
138 bool DeleteAtEndPressed() override; 139 bool DeleteAtEndPressed() override;
139 void UpdatePopup() override; 140 void UpdatePopup() override;
140 void ApplyCaretVisibility() override; 141 void ApplyCaretVisibility() override;
141 void OnTemporaryTextMaybeChanged(const base::string16& display_text, 142 void OnTemporaryTextMaybeChanged(const base::string16& display_text,
142 bool save_original_selection, 143 bool save_original_selection,
143 bool notify_text_changed) override; 144 bool notify_text_changed) override;
144 bool OnInlineAutocompleteTextMaybeChanged(const base::string16& display_text, 145 bool OnInlineAutocompleteTextMaybeChanged(const base::string16& display_text,
145 size_t user_text_length) override; 146 size_t user_text_length) override;
146 void OnInlineAutocompleteTextCleared() override; 147 void OnInlineAutocompleteTextCleared() override;
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 bool select_all_on_gesture_tap_; 245 bool select_all_on_gesture_tap_;
245 246
246 // The time of the first character insert operation that has not yet been 247 // The time of the first character insert operation that has not yet been
247 // painted. Used to measure omnibox responsiveness with a histogram. 248 // painted. Used to measure omnibox responsiveness with a histogram.
248 base::TimeTicks insert_char_time_; 249 base::TimeTicks insert_char_time_;
249 250
250 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 251 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
251 }; 252 };
252 253
253 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 254 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698