Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Issue 2891543002: [phone screen] Turn phone screen on for instrumentation tests

Created:
3 years, 7 months ago by shenghuazhang
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[screen] Turn phone screen on for instrumentation tests This CL works with provision_devices, which set devices disable the lock screen. This ensures the provision devices phone screen on for each instrumentation test. BUG=715583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
shenghuazhang
3 years, 7 months ago (2017-05-17 01:59:52 UTC) #2
jbudorick
3 years, 7 months ago (2017-05-17 03:15:50 UTC) #3
Per discussion on the bug: this is a good start, but we should also ensure this
behaves well in the non-provision (i.e. lock screen enabled) case by raising a
clear error if we can't turn the screen on.

Powered by Google App Engine
This is Rietveld 408576698