Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 2891493004: Tooltip for home page menu buttons (Closed)
Patch Set: edit documentation and fix error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
index 22307e7198f0ca92ceb0da8cdafbc85b3b475f90..381922532992ee59b1dda9d4249dd210743cf158 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
@@ -36,7 +36,8 @@ import java.util.Collection;
*/
@SuppressLint("Instantiatable")
-public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
+public class ToolbarTablet
+ extends ToolbarLayout implements OnClickListener, View.OnLongClickListener {
// The number of toolbar buttons that can be hidden at small widths (reload, back, forward).
public static final int HIDEABLE_BUTTON_COUNT = 3;
@@ -46,6 +47,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
private TintedImageButton mReloadButton;
private TintedImageButton mBookmarkButton;
private TintedImageButton mSaveOfflineButton;
+ private TintedImageButton mSecurityButton;
private ImageButton mAccessibilitySwitcherButton;
private OnClickListener mBookmarkListener;
@@ -94,6 +96,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mBackButton = (TintedImageButton) findViewById(R.id.back_button);
mForwardButton = (TintedImageButton) findViewById(R.id.forward_button);
mReloadButton = (TintedImageButton) findViewById(R.id.refresh_button);
+ mSecurityButton = (TintedImageButton) findViewById(R.id.security_button);
mShowTabStack = AccessibilityUtil.isAccessibilityEnabled();
mTabSwitcherButtonDrawable =
@@ -201,6 +204,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
});
mReloadButton.setOnClickListener(this);
+ mReloadButton.setOnLongClickListener(this);
mReloadButton.setOnKeyListener(new KeyboardNavigationListener() {
@Override
public View getNextFocusForward() {
@@ -223,6 +227,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mAccessibilitySwitcherButton.setOnClickListener(this);
mBookmarkButton.setOnClickListener(this);
+ mBookmarkButton.setOnLongClickListener(this);
mMenuButton.setOnKeyListener(new KeyboardNavigationListener() {
@Override
@@ -245,6 +250,9 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
}
mSaveOfflineButton.setOnClickListener(this);
+ mSaveOfflineButton.setOnLongClickListener(this);
+
+ mSecurityButton.setOnLongClickListener(this);
}
@Override
@@ -315,6 +323,27 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
}
}
+ @Override
+ public boolean onLongClick(View v) {
+ String description = null;
+ Context context = getContext();
+ final String tooltip_bookmark = context.getResources().getString(R.string.menu_bookmark);
+ final String tooltip_download = context.getResources().getString(R.string.menu_download);
+ final String tooltip_page_info = context.getResources().getString(R.string.menu_page_info);
+ final String tooltip_refresh = context.getResources().getString(R.string.menu_refresh);
+
+ if (v == mReloadButton) {
+ description = tooltip_refresh;
+ } else if (v == mBookmarkButton) {
+ description = tooltip_bookmark;
+ } else if (v == mSaveOfflineButton) {
+ description = tooltip_download;
+ } else if (v == mSecurityButton) {
+ description = tooltip_page_info;
+ }
+ return AccessibilityUtil.showAccessibilityToast(getContext(), v, description);
+ }
+
private void updateSwitcherButtonVisibility(boolean enabled) {
mAccessibilitySwitcherButton.setVisibility(mShowTabStack || enabled
? View.VISIBLE : View.GONE);

Powered by Google App Engine
This is Rietveld 408576698