chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 2891493004: Tooltip for home page menu buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2891493004: Tooltip for home page menu buttons (Closed)

Patch Set: tooltip for home page menu buttons Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/util/AccessibilityUtil.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 2abb265719d8413c1686c0a73587abd9cf7f1545..5a8949c1574bfc3e332fe08b56ffd3a8c036fdb7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -240,7 +240,6 @@ public class AppMenuPropertiesDelegate {

mAppMenuIconRowFooter = null;

return;

}

mdjones 2017/05/16 21:53:57 nit: Re-add this new-line since there are no other

huayinz 2017/05/16 22:59:42 Done.

mAppMenuIconRowFooter = (AppMenuIconRowFooter) promptView;

mAppMenuIconRowFooter.initialize(mActivity, menu, mBookmarkBridge);

}