Tooltip for home page menu buttons

chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
index 4631ee96f4f97274facaf241268a7c604d502b86..4f623defffc2cddac9be8832844aa2c62545fc82 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
@@ -35,9 +35,11 @@ import android.widget.PopupWindow.OnDismissListener;
 
 import org.chromium.base.AnimationFrameTimeHistogram;
 import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.base.ContextUtils;
 import org.chromium.base.SysUtils;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
+import org.chromium.chrome.browser.util.AccessibilityUtil;
 import org.chromium.chrome.browser.widget.PulseDrawable;
 
 import java.util.ArrayList;
@@ -376,6 +378,32 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {
         }
     }
 
+    /**
+     * Handles long clicks on image buttons on the AppMenu popup.
+     * @param menuItem The menu item in the popup that was long clicked.
+     * @param view The anchor view of the menu item

[mdjones, 2017/05/16 21:53:57]

nit: punctuation.

[huayinz, 2017/05/16 22:59:41]

Done.

+     */
+    boolean onItemLongClick(MenuItem menuItem, View view) {
+        if (menuItem.isEnabled()) {

[mdjones, 2017/05/16 21:53:56]

You can un-nest this by using an early return (in general this is considered
easier to read):

if (!menuItem.isEnabled()) return false;
...

[huayinz, 2017/05/16 22:59:42]

Done.

+            CharSequence description = null;

[mdjones, 2017/05/16 21:53:56]

nit: "String" would work just as well here (same for the other uses of
CharSequence in this patch).

[huayinz, 2017/05/16 22:59:42]

Done.

+            Context context = ContextUtils.getApplicationContext();
+            final int itemId = menuItem.getItemId();
+            if (itemId == R.id.forward_menu_id) {
+                description = context.getResources().getString(R.string.menu_forward);

[mdjones, 2017/05/16 21:53:56]

Making a local var for resources might make this block easier to read (similarly
for the other blocks in this patch).

[huayinz, 2017/05/16 22:59:41]

Done.

+            } else if (itemId == R.id.bookmark_this_page_id) {
+                description = context.getResources().getString(R.string.menu_bookmark);
+            } else if (itemId == R.id.offline_page_id) {
+                description = context.getResources().getString(R.string.menu_download);
+            } else if (itemId == R.id.info_menu_id) {
+                description = context.getResources().getString(R.string.menu_page_info);
+            } else if (itemId == R.id.reload_menu_id) {
+                description = context.getResources().getString(R.string.menu_refresh);
+            }
+            return AccessibilityUtil.showAccessibilityToast(context, view, description);
+        }
+        return false;
+    }
+
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
         onItemClick(mAdapter.getItem(position));