Chromium Code Reviews

Issue 2891493002: Revert of bluetooth: bluez: Fixed issue with missing notifications after reconnect. (Closed)

Created:
3 years, 7 months ago by rkc
Modified:
3 years, 7 months ago
Reviewers:
scheib, ortuno, rkc1, perja
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: bluez: Fixed issue with missing notifications after reconnect. (patchset #2 id:20001 of https://codereview.chromium.org/2625013003/ ) Reason for revert: Doesn't fix the issue correctly, introduces new issues. Original issue's description: > bluetooth: bluez: Fixed issue with missing notifications after reconnect. > > BUG=680099 > > Review-Url: https://codereview.chromium.org/2625013003 > Cr-Commit-Position: refs/heads/master@{#443451} > Committed: https://chromium.googlesource.com/chromium/src/+/db61493317991225f05f657bc5c78db7f96d55a7 TBR=ortuno@chromium.org,rkc@google.com,scheib@chromium.org,perja@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680099

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+8 lines, -13 lines)
M device/bluetooth/bluetooth_device.h View 1 chunk +1 line, -1 line 0 comments
M device/bluetooth/bluetooth_device.cc View 2 chunks +2 lines, -7 lines 0 comments
M device/bluetooth/bluetooth_device_android.cc View 1 chunk +4 lines, -1 line 0 comments
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 chunk +1 line, -1 line 0 comments
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 chunk +0 lines, -3 lines 0 comments

Messages

Total messages: 8 (2 generated)
rkc
Created Revert of bluetooth: bluez: Fixed issue with missing notifications after reconnect.
3 years, 7 months ago (2017-05-16 18:45:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891493002/1
3 years, 7 months ago (2017-05-16 18:46:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/140487) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-16 18:51:45 UTC) #5
scheib
On 2017/05/16 18:51:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-16 20:08:27 UTC) #6
rkc
Sonny has already uploaded a rebased revert here: https://codereview.chromium.org/2888663002/
3 years, 7 months ago (2017-05-16 20:11:21 UTC) #7
scheib
3 years, 7 months ago (2017-05-16 20:11:38 UTC) #8
Message was sent while issue was closed.
On 2017/05/16 20:08:27, scheib wrote:
> On 2017/05/16 18:51:45, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_cronet on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
> >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> >   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> I will revert manually.

Ah, already being done in: https://codereview.chromium.org/2888663002/

Powered by Google App Engine