Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2759)

Unified Diff: content/renderer/shared_worker/embedded_shared_worker_stub.cc

Issue 2891453005: Pipe the FirstPartyForCookies to WorkerFetchContext for off-main-thread-fetch (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/shared_worker/embedded_shared_worker_stub.cc
diff --git a/content/renderer/shared_worker/embedded_shared_worker_stub.cc b/content/renderer/shared_worker/embedded_shared_worker_stub.cc
index 090ba0ea4fd31039ad3866583fe56dec69014507..6d666ada05ba639624e2f2efcc0c1b38bf4b59a5 100644
--- a/content/renderer/shared_worker/embedded_shared_worker_stub.cc
+++ b/content/renderer/shared_worker/embedded_shared_worker_stub.cc
@@ -272,6 +272,10 @@ EmbeddedSharedWorkerStub::CreateWorkerFetchContext(
std::unique_ptr<WorkerFetchContextImpl> worker_fetch_context =
base::MakeUnique<WorkerFetchContextImpl>(
worker_url_loader_factory_provider.PassInterface());
+ // TODO(horo): To get the correct first_party_to_cookies for the shared
+ // worker, we need to check the all documents bounded by the shared worker.
+ // https://tools.ietf.org/html/draft-west-first-party-cookies-07#section-2.1.2
falken 2017/05/17 08:55:31 This sounds serious. Shall we open a bug for this?
horo 2017/05/17 09:44:03 Filed crbug.com/723553
+ worker_fetch_context->set_first_party_for_cookies(url_);
if (web_network_provider) {
ServiceWorkerNetworkProvider* network_provider =
ServiceWorkerNetworkProvider::FromWebServiceWorkerNetworkProvider(

Powered by Google App Engine
This is Rietveld 408576698