Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2891453003: Incorporate ComputedStyle::hasTransform when diffing transform styles. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index b4c6969b84aa3dba8e4cd623c63b7442f38bf391..6dc32221664c0687234f3b9aedcaae6e58e41b93 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -389,8 +389,13 @@ void PaintLayer::updateTransformationMatrix() {
void PaintLayer::updateTransform(const ComputedStyle* oldStyle,
const ComputedStyle& newStyle) {
- if (oldStyle && newStyle.transformDataEquivalent(*oldStyle))
+ // It's possible for the old and new style transform data to be equivalent
+ // while hasTransform() differs, as it checks a number of conditions aside
+ // from just the matrix, including but not limited to animation state.
+ if (oldStyle && oldStyle->hasTransform() == newStyle.hasTransform() &&
+ newStyle.transformDataEquivalent(*oldStyle)) {
return;
+ }
// hasTransform() on the layoutObject is also true when there is
// transform-style: preserve-3d or perspective set, so check style too.
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698