chromeos/network/client_cert_util.cc - Issue 2891453002: Introduce networkingPrivate.getCertificateLists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/client_cert_util.cc

Issue 2891453002: Introduce networkingPrivate.getCertificateLists (Closed)

Patch Set: Rebase, fix histograms, remove from networking.onc Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/client_cert_util.cc

diff --git a/chromeos/network/client_cert_util.cc b/chromeos/network/client_cert_util.cc

index 735ee2ca067ccc2a537afcbaab658d5c90512a55..66d1df195ed22554867fb287ef8a50e847d7bf00 100644

--- a/chromeos/network/client_cert_util.cc

+++ b/chromeos/network/client_cert_util.cc

@@ -27,10 +27,10 @@ namespace chromeos {

namespace client_cert {

-namespace {

const char kDefaultTPMPin[] = "111111";

+namespace {

std::string GetStringFromDictionary(const base::DictionaryValue& dict,

const std::string& key) {

std::string s;