Issue 289143002: Reland: Fix X11TopmostWindowFinder

Issue 289143002: Reland: Fix X11TopmostWindowFinder (Closed)

Created:
6 years, 7 months ago by pkotwicz

Modified:
6 years, 7 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix X11TopmostWindowFinder to take into account - Window manager provided window borders - Custom shapes specified via views::Widget::SetShape() BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271077

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+499 lines, -74 lines)			Patch
M	ui/base/x/x11_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View		3 chunks	+8 lines, -9 lines	0 comments	Download
M	ui/views/views.gyp	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	1 comment	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h	View		4 chunks	+23 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View		10 chunks	+96 lines, -58 lines	0 comments	Download
A	ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc	View		1 chunk	+338 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/x11_topmost_window_finder.cc	View		3 chunks	+22 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Sadrul, PTAL. Patch set #1 has the code as it landed in https://codereview.chromium.org/268673017/ https://codereview.chromium.org/289143002/diff/10001/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc File ...

6 years, 7 months ago (2014-05-16 16:56:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/289143002/10001

6 years, 7 months ago (2014-05-16 17:20:00 UTC) #4

Message was sent while issue was closed.

Change committed as 271077

Expand Messages | Collapse Messages