Disable NTP URL bar while in VR on Android.

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp;
 
 import android.annotation.TargetApi;
 import android.content.Context;
 import android.graphics.Canvas;
 import android.graphics.Point;
@@ skipping 75 matching lines @@
     private final int mThemeColor;
     private final NewTabPageView mNewTabPageView;
     private final NewTabPageManagerImpl mNewTabPageManager;
     private final TileGroup.Delegate mTileGroupDelegate;
 
     private TabObserver mTabObserver;
     private boolean mSearchProviderHasLogo;
     private FakeboxDelegate mFakeboxDelegate;
     private SnippetsBridge mSnippetsBridge;
 
+    private boolean mVoiceInputEnabled = true;
+
     // The timestamp at which the constructor was called.
     private final long mConstructedTimeNs;
 
     // The timestamp at which this NTP was last shown to the user.
     private long mLastShownTimeNs;
 
     private boolean mIsLoaded;
 
     // Whether destroy() has been called.
     private boolean mIsDestroyed;
@@ skipping 39 matching lines @@
          *
          * @param pastedText The text that was pasted or typed into the fakebox, or null if the user
          *                   just tapped the fakebox.
          */
         void requestUrlFocusFromFakebox(String pastedText);
 
         /**
          * @return whether the provided native page is the one currently displayed to the user.
          */
         boolean isCurrentPage(NativePage nativePage);
+
+        /**
+         * See LocationBarLayout#setUrlBarFocusable.
+         */
+        void setUrlBarFocusable(boolean focusable);

[Ted C, 2017/06/02 17:01:51]

I feel there needs to be a path where this is isolated entirely within the NTP
package.  We shouldn't need to disable the omnibox as that view is hidden when
entering VR.

You can change focusSearchBox to return within the NewTabPage.java.  You can set
the fake box to invisible, you can disable it and the voice button.

     }
 
     /**
      * @param url The URL to check whether it is for the NTP.
      * @return Whether the passed in URL is used to render the NTP.
      */
     public static boolean isNTPUrl(String url) {
         // Also handle the legacy chrome://newtab URL since that will redirect to
         // chrome-native://newtab natively.
         return url != null
@@ skipping 22 matching lines @@
         @Override
         public boolean isLocationBarShownInNTP() {
             if (mIsDestroyed) return false;
             Context context = mNewTabPageView.getContext();
             return isInSingleUrlBarMode(context)
                     && !mNewTabPageView.urlFocusAnimationsDisabled();
         }
 
         @Override
         public boolean isVoiceSearchEnabled() {
-            return mFakeboxDelegate != null && mFakeboxDelegate.isVoiceSearchEnabled();
+            return mVoiceInputEnabled && mFakeboxDelegate != null
+                    && mFakeboxDelegate.isVoiceSearchEnabled();
         }
 
         @TargetApi(Build.VERSION_CODES.LOLLIPOP)
         private boolean switchToExistingTab(String url) {
             String matchPattern = CommandLine.getInstance().getSwitchValue(
                     ChromeSwitches.NTP_SWITCH_TO_EXISTING_TAB);
             boolean matchByHost;
             if ("url".equals(matchPattern)) {
                 matchByHost = false;
             } else if ("host".equals(matchPattern)) {
@@ skipping 190 matching lines @@
     }
 
     /**
      * Updates whether the NewTabPage should animate on URL focus changes.
      * @param disable Whether to disable the animations.
      */
     public void setUrlFocusAnimationsDisabled(boolean disable) {
         mNewTabPageView.setUrlFocusAnimationsDisabled(disable);
     }
 
+    /**
+     * Updates whether input to the URL bar should be enabled.
+     * @param enable Whether to enable URL Bar input.
+     */
+    public void setUrlBarInputEnabled(boolean enable) {
+        mFakeboxDelegate.setUrlBarFocusable(enable);
+        mVoiceInputEnabled = enable;
+        mNewTabPageView.updateVoiceSearchButtonVisibility();
+    }
+
     private boolean isInSingleUrlBarMode(Context context) {
         if (DeviceFormFactor.isTablet()) return false;
         if (FeatureUtilities.isChromeHomeEnabled()) return false;
         return mSearchProviderHasLogo;
     }
 
     private void updateSearchProviderHasLogo() {
         mSearchProviderHasLogo = TemplateUrlService.getInstance().isDefaultSearchEngineGoogle();

[Ted C, 2017/05/23 14:37:45]

Is it better UI if VR would to fall into this path?  Set your search engine to
something other than google and see if all the UI that you can't interact with
is hidden.

On a tangent, I wonder if we should try to converge on something like
VrTabHelper in Java as well where here we would have something like
VrTabHelper.isInVr(webContents()).  The gotcha is that does add VR specific
stuff else where, but maybe that is better in terms of consistency.

[mthiesse, 2017/05/31 21:27:11]

Hmm I don't personally think the UI is better when we change the search engine.
Mainly I like the consistency of the NTP looking the same in and out of VR, and
the Google Doodle is great (the NTP looks so barren without it).

It might look better if the NTP made it visually apparent that URL bar input was
disabled, but I think that's very non-urgent.

The search input field also being present/selectable without the keyboard
popping up is consistent with the rest of VR at the moment.


As for VrTabHelper.isInVr(webContents()), I don't really see the point of this
here. We already have VrShellDelegate.isInVr(), and I think from the browser's
perspective we're in VR or we aren't (at least on Android). You can't have some
WebContents in VR and some not.

I'd be okay with using VrShellDelegate.isInVr(), but we would still have to
either manually call some update function, or provide a way for listeners to
listen to VR-ness changing. Is this something we want?
VrShellDelegate.registerVrStateListener()?

     }
 
     private void onSearchEngineUpdated() {
         // TODO(newt): update this if other search providers provide logos.
         updateSearchProviderHasLogo();
         mNewTabPageView.setSearchProviderHasLogo(mSearchProviderHasLogo);
     }
 
     /**
      * Specifies the percentage the URL is focused during an animation.  1.0 specifies that the URL
@@ skipping 191 matching lines @@
     @Override
     public void captureThumbnail(Canvas canvas) {
         mNewTabPageView.captureThumbnail(canvas);
     }
 
     @VisibleForTesting
     public NewTabPageManager getManagerForTesting() {
         return mNewTabPageManager;
     }
 }