Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js

Issue 2891383002: Force non overlay scrollbar in Devtools/Performance for Aura Overlay Scrollbar (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {Common.App} 5 * @implements {Common.App}
6 * @unrestricted 6 * @unrestricted
7 */ 7 */
8 Emulation.AdvancedApp = class { 8 Emulation.AdvancedApp = class {
9 constructor() { 9 constructor() {
10 Components.dockController.addEventListener( 10 Components.dockController.addEventListener(
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 var url = window.location.href.replace('inspector.html', 'toolbox.html'); 65 var url = window.location.href.replace('inspector.html', 'toolbox.html');
66 this._toolboxWindow = window.open(url, undefined); 66 this._toolboxWindow = window.open(url, undefined);
67 } 67 }
68 68
69 /** 69 /**
70 * @param {!Document} toolboxDocument 70 * @param {!Document} toolboxDocument
71 */ 71 */
72 toolboxLoaded(toolboxDocument) { 72 toolboxLoaded(toolboxDocument) {
73 UI.initializeUIUtils(toolboxDocument, Common.settings.createSetting('uiTheme ', 'default')); 73 UI.initializeUIUtils(toolboxDocument, Common.settings.createSetting('uiTheme ', 'default'));
74 UI.installComponentRootStyles(/** @type {!Element} */ (toolboxDocument.body) ); 74 UI.installComponentRootStyles(toolboxDocument, /** @type {!Element} */ (tool boxDocument.body));
alph 2017/05/22 18:50:08 You don't need a document. Please check how we do
75 UI.ContextMenu.installHandler(toolboxDocument); 75 UI.ContextMenu.installHandler(toolboxDocument);
76 UI.Tooltip.installHandler(toolboxDocument); 76 UI.Tooltip.installHandler(toolboxDocument);
77 77
78 this._toolboxRootView = new UI.RootView(); 78 this._toolboxRootView = new UI.RootView();
79 this._toolboxRootView.attachToDocument(toolboxDocument); 79 this._toolboxRootView.attachToDocument(toolboxDocument);
80 80
81 this._updateDeviceModeView(); 81 this._updateDeviceModeView();
82 } 82 }
83 83
84 _updateDeviceModeView() { 84 _updateDeviceModeView() {
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 */ 192 */
193 Emulation.AdvancedAppProvider = class { 193 Emulation.AdvancedAppProvider = class {
194 /** 194 /**
195 * @override 195 * @override
196 * @return {!Common.App} 196 * @return {!Common.App}
197 */ 197 */
198 createApp() { 198 createApp() {
199 return Emulation.AdvancedApp._instance(); 199 return Emulation.AdvancedApp._instance();
200 } 200 }
201 }; 201 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698