Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: build/check_gn_headers_unittest.py

Issue 2891363004: Add helpful error messages to check_gn_headers.py (Closed)
Patch Set: gn gen in temp dir Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers_unittest.py
diff --git a/build/check_gn_headers_unittest.py b/build/check_gn_headers_unittest.py
index 892fa6613e39a74d127a11c536462e244e70dfa1..78c78776a15544cc11e4ebab88727e782926d850 100755
--- a/build/check_gn_headers_unittest.py
+++ b/build/check_gn_headers_unittest.py
@@ -44,7 +44,7 @@ gn_input = json.loads(r'''
},
"//:star_public": {
"public": "*",
- "sources": [ "//base/c.h" ],
+ "sources": [ "//base/c.h", "//tmp/gen/a.h" ],
"visibility": [ "*" ]
}
}
@@ -90,12 +90,14 @@ class CheckGnHeadersTest(unittest.TestCase):
os.sep = old_sep
def testGn(self):
- headers = check_gn_headers.ParseGNProjectJSON(gn_input)
+ headers = check_gn_headers.ParseGNProjectJSON(gn_input,
+ 'out/Release', 'tmp')
expected = set([
'base/a.h',
'base/b.hh',
'base/c.h',
'base/p.h',
+ 'out/Release/gen/a.h',
])
self.assertEquals(headers, expected)
« no previous file with comments | « build/check_gn_headers.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698