Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: components/history/core/browser/history_backend_unittest.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)
Patch Set: Updated iOS code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_backend_unittest.cc
diff --git a/components/history/core/browser/history_backend_unittest.cc b/components/history/core/browser/history_backend_unittest.cc
index 48cee5bf8d9c4a2d877b37456fde6833b6678d09..63dfe4b73094472f69d092164756c5ebca68bf4b 100644
--- a/components/history/core/browser/history_backend_unittest.cc
+++ b/components/history/core/browser/history_backend_unittest.cc
@@ -1791,9 +1791,23 @@ TEST_F(HistoryBackendTest, SetFaviconMappingsForPageAndRedirects) {
0u,
NumIconMappingsForPageURL(url1, favicon_base::TOUCH_PRECOMPOSED_ICON));
+ // Add a web manifest_icon.
+ backend_->SetFavicons(url1, favicon_base::WEB_MANIFEST_ICON, icon_url2,
+ bitmaps);
+ EXPECT_EQ(1u,
+ NumIconMappingsForPageURL(url1, favicon_base::WEB_MANIFEST_ICON));
+ EXPECT_EQ(1u, NumIconMappingsForPageURL(url1, favicon_base::FAVICON));
+ // The TOUCH_ICON_ICON was replaced.
+ EXPECT_EQ(0u, NumIconMappingsForPageURL(url1, favicon_base::TOUCH_ICON));
+
+ // The TOUCH_PRECOMPOSED_ICON was replaced.
+ EXPECT_EQ(0u, NumIconMappingsForPageURL(
+ url1, favicon_base::TOUCH_PRECOMPOSED_ICON));
+
// Add a different favicon.
backend_->SetFavicons(url1, favicon_base::FAVICON, icon_url2, bitmaps);
- EXPECT_EQ(1u, NumIconMappingsForPageURL(url1, favicon_base::TOUCH_ICON));
+ EXPECT_EQ(1u,
+ NumIconMappingsForPageURL(url1, favicon_base::WEB_MANIFEST_ICON));
EXPECT_EQ(1u, NumIconMappingsForPageURL(url1, favicon_base::FAVICON));
EXPECT_EQ(1u, NumIconMappingsForPageURL(url2, favicon_base::FAVICON));
}

Powered by Google App Engine
This is Rietveld 408576698