components/favicon/ios/favicon_url_util.cc - Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/ios/favicon_url_util.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)

Patch Set: Put browsertest behind #if. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/ios/favicon_url_util.cc

diff --git a/components/favicon/ios/favicon_url_util.cc b/components/favicon/ios/favicon_url_util.cc

index 95bcfda262b4a424b7ec2e1757b3d572d1351a39..54b072c50657f3b98b9795b07f3d4a381f9e9d4e 100644

--- a/components/favicon/ios/favicon_url_util.cc

+++ b/components/favicon/ios/favicon_url_util.cc

@@ -23,6 +23,8 @@ favicon_base::IconType IconTypeFromWebIconType(

return favicon_base::TOUCH_ICON;

case web::FaviconURL::TOUCH_PRECOMPOSED_ICON:

return favicon_base::TOUCH_PRECOMPOSED_ICON;

+ case web::FaviconURL::WEB_MANIFEST_ICON:

+ return favicon_base::WEB_MANIFEST_ICON;

case web::FaviconURL::INVALID_ICON:

return favicon_base::INVALID_ICON;

}