components/favicon/core/large_icon_service.cc - Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/large_icon_service.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)

Patch Set: Put browsertest behind #if. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/large_icon_service.cc

diff --git a/components/favicon/core/large_icon_service.cc b/components/favicon/core/large_icon_service.cc

index df9f2e32e5a1db688c0f269cb33f14789e74bf9e..bc2ebc2e4554b1ddc9f834e6fdf58a40e4b4e5d1 100644

--- a/components/favicon/core/large_icon_service.cc

+++ b/components/favicon/core/large_icon_service.cc

@@ -311,6 +311,7 @@ LargeIconService::LargeIconService(

: favicon_service_(favicon_service),

background_task_runner_(background_task_runner),

image_fetcher_(std::move(image_fetcher)) {

+ large_icon_types_.push_back(favicon_base::IconType::WEB_MANIFEST_ICON);

large_icon_types_.push_back(favicon_base::IconType::FAVICON);

large_icon_types_.push_back(favicon_base::IconType::TOUCH_ICON);

large_icon_types_.push_back(favicon_base::IconType::TOUCH_PRECOMPOSED_ICON);