components/favicon/content/content_favicon_driver.cc - Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)

Patch Set: Put browsertest behind #if. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/content/content_favicon_driver.cc

diff --git a/components/favicon/content/content_favicon_driver.cc b/components/favicon/content/content_favicon_driver.cc

index 00442d00fa7dc27d77de5d90406c2c39d8354bb5..ece84e5ddac47ab7cd038887bce1a19a2ac1b1dc 100644

--- a/components/favicon/content/content_favicon_driver.cc

+++ b/components/favicon/content/content_favicon_driver.cc

@@ -31,7 +31,8 @@ void ExtractManifestIcons(

const content::Manifest& manifest) {

std::vector<FaviconURL> candidates;

for (const content::Manifest::Icon& icon : manifest.icons) {

- candidates.emplace_back(icon.src, favicon_base::FAVICON, icon.sizes);

+ candidates.emplace_back(icon.src, favicon_base::WEB_MANIFEST_ICON,

+ icon.sizes);

}

callback.Run(candidates);

}