Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: chrome/browser/favicon/content_favicon_driver_browsertest.cc

Issue 2891333002: Introduce dedicated enum value for icons from Web Manifests (Closed)
Patch Set: Put browsertest behind #if. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/content_favicon_driver_browsertest.cc
diff --git a/chrome/browser/favicon/content_favicon_driver_browsertest.cc b/chrome/browser/favicon/content_favicon_driver_browsertest.cc
index c62373483b870ff2a50d1c1580d13110ff893a2e..88b785267c9a80cb6675a75ce538fabed09c0ae7 100644
--- a/chrome/browser/favicon/content_favicon_driver_browsertest.cc
+++ b/chrome/browser/favicon/content_favicon_driver_browsertest.cc
@@ -279,7 +279,11 @@ IN_PROC_BROWSER_TEST_F(ContentFaviconDriverTest, LoadIconFromWebManifest) {
ui_test_utils::BROWSER_TEST_NONE);
waiter.Wait();
+#if defined(OS_ANDROID) || defined(OS_IOS)
EXPECT_TRUE(delegate->was_requested());
+#else
+ EXPECT_FALSE(delegate->was_requested());
+#endif
}
// Test that loading a page that contains a Web Manifest without icons and a

Powered by Google App Engine
This is Rietveld 408576698