Add a enterprise enrollment check screen to OOBE in ChromeOS.

Add a enterprise enrollment check screen to OOBE in ChromeOS.

BUG=372403
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273910

[pastarmovj, 2014-05-19 15:27:28]

Hey Mattias,
I know we are still waiting on the final wording and design but it will be great
if you can already have a look at this CL before I throw it at the larger
audience.
Cheers,
Julian

[Mattias Nissler (ping if slow), 2014-05-19 19:25:50]

https://codereview.chromium.org/289133002/diff/20001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:2739: Performing auto-enrollment check
Let's fix the wording here as well to be more generic.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:30: if
(actor_)
indentation

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:67:
actor_->Show();
I don't think we should even call actor_->Show() if we already know the result
of the check.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:499:
SetStatusAreaVisible(true);
Why? I think the status area is supposed to be hidden during all of OOBE, and
this screen only shows during OOBE.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:360: }
nit: blank line

[pastarmovj, 2014-05-20 13:50:08]

Hi guys,
I think this CL is now review ready. It is based on
https://codereview.chromium.org/275913004 so it won't get in before the other
one is ready.

https://codereview.chromium.org/289133002/diff/20001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:2739: Performing auto-enrollment check
On 2014/05/19 19:25:51, Mattias Nissler wrote:
> Let's fix the wording here as well to be more generic.

Done.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:30: if
(actor_)
On 2014/05/19 19:25:51, Mattias Nissler wrote:
> indentation

Done.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:67:
actor_->Show();
On 2014/05/19 19:25:51, Mattias Nissler wrote:
> I don't think we should even call actor_->Show() if we already know the result
> of the check.

Done.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:499:
SetStatusAreaVisible(true);
On 2014/05/19 19:25:51, Mattias Nissler wrote:
> Why? I think the status area is supposed to be hidden during all of OOBE, and
> this screen only shows during OOBE.

All other OOBE screens are like that - see ShowEulaScreen or
ShowEnrollmentScreen.

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/289133002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:360: }
On 2014/05/19 19:25:51, Mattias Nissler wrote:
> nit: blank line

Done.

[ygorshenin1, 2014-05-20 16:54:40]

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:29:
DCHECK(actor_);
Why do you need this DCHECK()? In the following code you're always checking that
actor_ is not null before accessing it.

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_actor.h
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_actor.h:8:
#include <string>
Delete this.

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.css
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.css:1:
/* Copyright 2013 The Chromium Authors. All rights reserved.
s/2013/2014/

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc:1:
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
s/\(c\) 2013/2014/

[pastarmovj, 2014-05-22 13:41:43]

Thanks for reviewing!

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc:29:
DCHECK(actor_);
On 2014/05/20 16:54:40, ygorshenin1 wrote:
> Why do you need this DCHECK()? In the following code you're always checking
that
> actor_ is not null before accessing it.

Correct. This is an artifact from the code I copied.

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_actor.h
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_actor.h:8:
#include <string>
On 2014/05/20 16:54:40, ygorshenin1 wrote:
> Delete this.

Done.

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.css
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.css:1:
/* Copyright 2013 The Chromium Authors. All rights reserved.
On 2014/05/20 16:54:40, ygorshenin1 wrote:
> s/2013/2014/

Done.

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc
(right):

https://codereview.chromium.org/289133002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc:1:
// Copyright (c) 2013 The Chromium Authors. All rights reserved.
On 2014/05/20 16:54:40, ygorshenin1 wrote:
> s/\(c\) 2013/2014/

Done.

[ygorshenin1, 2014-05-27 09:53:11]

lgtm

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc
(right):

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc:1:
// Copyright (c) 2014 The Chromium Authors. All rights reserved.
nit: delete "(c)"

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h
(right):

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h:1:
// Copyright (c) 2014 The Chromium Authors. All rights reserved.
nit: delete "(c)"

[pastarmovj, 2014-05-28 09:12:32]

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc
(right):

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc:1:
// Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/05/27 09:53:11, ygorshenin1 wrote:
> nit: delete "(c)"

Done.

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
File
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h
(right):

https://codereview.chromium.org/289133002/diff/70001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h:1:
// Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/05/27 09:53:11, ygorshenin1 wrote:
> nit: delete "(c)"

Done.

[pastarmovj, 2014-05-28 09:12:58]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2014-05-28 09:13:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/289133002/80001

[commit-bot: I haz the power, 2014-05-28 12:29:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-28 12:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 12:32:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[pastarmovj, 2014-05-30 14:03:39]

Hey Yuri,

can you please take a quick scan. I had to add mocks for the new classes and
adjust the browser tests because they were now getting stuck on unexpected
window along the way.
Otherwise no changes to the actual logic.

Thanks,
Julian

[Nikita (slow), 2014-05-30 14:54:42]

lgtm

[pastarmovj, 2014-05-30 15:17:12]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2014-05-30 15:18:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/289133002/120001

[commit-bot: I haz the power, 2014-05-30 20:58:58]

Change committed as 273910