Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2891203002: Make user-triggered SelectAll act as if there is no selection for hidden selection (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 121
122 void SetSelection(const SelectionInFlatTree&, 122 void SetSelection(const SelectionInFlatTree&,
123 SetSelectionOptions = kCloseTyping | kClearTypingStyle, 123 SetSelectionOptions = kCloseTyping | kClearTypingStyle,
124 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded, 124 CursorAlignOnScroll = CursorAlignOnScroll::kIfNeeded,
125 TextGranularity = kCharacterGranularity); 125 TextGranularity = kCharacterGranularity);
126 bool SetSelectedRange( 126 bool SetSelectedRange(
127 const EphemeralRange&, 127 const EphemeralRange&,
128 TextAffinity, 128 TextAffinity,
129 SelectionDirectionalMode = SelectionDirectionalMode::kNonDirectional, 129 SelectionDirectionalMode = SelectionDirectionalMode::kNonDirectional,
130 FrameSelection::SetSelectionOptions = kCloseTyping | kClearTypingStyle); 130 FrameSelection::SetSelectionOptions = kCloseTyping | kClearTypingStyle);
131 void SelectAll(); 131 void SelectAll(EUserTriggered = kNotUserTriggered);
132 void Clear(); 132 void Clear();
133 bool IsHidden() const; 133 bool IsHidden() const;
134 134
135 // TODO(tkent): These two functions were added to fix crbug.com/695211 without 135 // TODO(tkent): These two functions were added to fix crbug.com/695211 without
136 // changing focus behavior. Once we fix crbug.com/690272, we can remove these 136 // changing focus behavior. Once we fix crbug.com/690272, we can remove these
137 // functions. 137 // functions.
138 // setSelectionDeprecated() returns true if didSetSelectionDeprecated() should 138 // setSelectionDeprecated() returns true if didSetSelectionDeprecated() should
139 // be called. 139 // be called.
140 bool SetSelectionDeprecated(const SelectionInDOMTree&, 140 bool SetSelectionDeprecated(const SelectionInDOMTree&,
141 SetSelectionOptions = kCloseTyping | 141 SetSelectionOptions = kCloseTyping |
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 313
314 } // namespace blink 314 } // namespace blink
315 315
316 #ifndef NDEBUG 316 #ifndef NDEBUG
317 // Outside the WebCore namespace for ease of invocation from gdb. 317 // Outside the WebCore namespace for ease of invocation from gdb.
318 void showTree(const blink::FrameSelection&); 318 void showTree(const blink::FrameSelection&);
319 void showTree(const blink::FrameSelection*); 319 void showTree(const blink::FrameSelection*);
320 #endif 320 #endif
321 321
322 #endif // FrameSelection_h 322 #endif // FrameSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698