Make user-triggered SelectAll act as if there is no selection for hidden selection

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 638 matching lines @@
 }
 
 // Returns a shadow tree node for legacy shadow trees, a child of the
 // ShadowRoot node for new shadow trees, or 0 for non-shadow trees.
 static Node* NonBoundaryShadowTreeRootNode(const Position& position) {
   return position.AnchorNode() && !position.AnchorNode()->IsShadowRoot()
              ? position.AnchorNode()->NonBoundaryShadowTreeRootNode()
              : nullptr;
 }
 
-void FrameSelection::SelectAll() {
+void FrameSelection::SelectAll(EUserTriggered user_triggered) {
   if (isHTMLSelectElement(GetDocument().FocusedElement())) {
     HTMLSelectElement* select_element =
         toHTMLSelectElement(GetDocument().FocusedElement());
     if (select_element->CanSelectAll()) {
       select_element->SelectAll();
       return;
     }
   }
 
   Node* root = nullptr;
   Node* select_start_target = nullptr;
-  if (ComputeVisibleSelectionInDOMTree().IsContentEditable()) {
+  if (user_triggered == kUserTriggered && IsHidden()) {
+    // Hidden selection appears as no selection to user, in which case user-
+    // triggered SelectAll should act as if there is no selection.
+    root = GetDocument().documentElement();
+    select_start_target = GetDocument().body();
+  } else if (ComputeVisibleSelectionInDOMTree().IsContentEditable()) {
     root = HighestEditableRoot(ComputeVisibleSelectionInDOMTree().Start());
     if (Node* shadow_root = NonBoundaryShadowTreeRootNode(
             ComputeVisibleSelectionInDOMTree().Start()))
       select_start_target = shadow_root->OwnerShadowHost();
     else
       select_start_target = root;
   } else {
     root = NonBoundaryShadowTreeRootNode(
         ComputeVisibleSelectionInDOMTree().Start());
     if (root) {
@@ skipping 14 matching lines @@
     // The frame may be detached due to selectstart event.
     if (!IsAvailable()) {
       // Reached by editing/selection/selectstart_detach_frame.html
       return;
     }
     // |root| may be detached due to selectstart event.
     if (!root->isConnected() || expected_document != root->GetDocument())
       return;
   }
 
+  // TODO(editing-dev): Should we pass in user_triggered?

[yosin_UTC9, 2017/05/19 02:19:36]

Duplicated to L717? Or, do we want to pass |user_triggered| to
|SelectFrameElementInParentIfFullySelected()|?

[Xiaocheng, 2017/05/19 02:25:51]

Not duplicate. SetSelection() takes an |option| which allows to specify if the
selection change is user triggered or not.

   SetSelection(SelectionInDOMTree::Builder()
                    .SelectAllChildren(*root)
                    .SetIsHandleVisible(IsHandleVisible())
                    .Build());
   SelectFrameElementInParentIfFullySelected();
+  // TODO(editing-dev): Should we pass in user_triggered?
   NotifyTextControlOfSelectionChange(kUserTriggered);
 }
 
 bool FrameSelection::SetSelectedRange(const EphemeralRange& range,
                                       TextAffinity affinity,
                                       SelectionDirectionalMode directional,
                                       SetSelectionOptions options) {
   if (range.IsNull())
     return false;
   SetSelection(SelectionInDOMTree::Builder()
@@ skipping 497 matching lines @@
 }
 
 void showTree(const blink::FrameSelection* sel) {
   if (sel)
     sel->ShowTreeForThis();
   else
     LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif