Add support for converted closures with explicit contexts to VM

runtime/vm/kernel_binary_flowgraph.h

Index: runtime/vm/kernel_binary_flowgraph.h
diff --git a/runtime/vm/kernel_binary_flowgraph.h b/runtime/vm/kernel_binary_flowgraph.h
index 4667e5152d1be8c4b134e8e9b40f62340486f9a3..f07cc8d8a7dd26b5f13defae166642c679b249bd 100644
--- a/runtime/vm/kernel_binary_flowgraph.h
+++ b/runtime/vm/kernel_binary_flowgraph.h
@@ -119,6 +119,7 @@ class StreamingScopeBuilder {
   void VisitInterfaceType(bool simple);
   void VisitFunctionType(bool simple);
   void VisitTypeParameterType();
+  void VisitVectorType();
   void HandleLocalFunction(intptr_t parent_kernel_offset);
 
   void EnterScope(intptr_t kernel_offset);
@@ -383,6 +384,7 @@ class StreamingFlowGraphBuilder {
   Fragment BuildFieldInitializer(NameIndex canonical_name);
   Fragment BuildInitializers(intptr_t constructor_class_parent_offset);
   FlowGraph* BuildGraphOfImplicitClosureFunction(const Function& function);
+  FlowGraph* BuildGraphOfConvertedClosureFunction(const Function& function);
   FlowGraph* BuildGraphOfFunction(
       bool is_in_builtin_library_toplevel,
       intptr_t constructor_class_parent_offset = -1);
@@ -449,6 +451,7 @@ class StreamingFlowGraphBuilder {
   BreakableBlock* breakable_block();
   GrowableArray<YieldContinuation>& yield_continuations();
   Value* stack();
+  void Push(Definition* definition);
   Value* Pop();
 
   Tag PeekArgumentsFirstPositionalTag();
@@ -501,8 +504,13 @@ class StreamingFlowGraphBuilder {
       const TypeArguments& type_arguments);
   Fragment StrictCompare(Token::Kind kind, bool number_check = false);
   Fragment AllocateObject(const dart::Class& klass, intptr_t argument_count);
+  Fragment AllocateObject(const dart::Class& klass,
+                          const Function& closure_function);
+  Fragment LoadField(intptr_t offset);
+  Fragment AllocateContext(int size);

[kustermann, 2017/06/20 12:13:14]

s/int/intptr_t/

Although it makes little difference here, our "guidelines" says to prefer
intptr_t over int.

[Dmitry Stefantsov, 2017/06/22 14:12:52]

I agree that using `intptr_t` here is more aligned with our conventions, but
this method redirects to `AllocateContext(int)` method of `FlowGraphBuilder` in
runtime/vm/kernel_to_il.h.  In turn, it should be in check with
`PushContext(int)` of `FlowGraphBuilder` which sometimes is called with an `int`
obtained from `num_context_variables` of `LocalScope`.

So, changing `int` to `intptr_t` here would require changing it in all those
places.  I don't mind trying to do it, but it may affect some areas that I might
be unaware of.  It would be great to know your opinion on this, Martin.

   Fragment StoreLocal(TokenPosition position, LocalVariable* variable);
   Fragment StoreStaticField(TokenPosition position, const dart::Field& field);
+  Fragment StoreInstanceField(TokenPosition position, intptr_t offset);
   Fragment StringInterpolate(TokenPosition position);
   Fragment StringInterpolateSingle(TokenPosition position);
   Fragment ThrowTypeError();
@@ -590,6 +598,11 @@ class StreamingFlowGraphBuilder {
   Fragment BuildDoubleLiteral(TokenPosition* position);
   Fragment BuildBoolLiteral(bool value, TokenPosition* position);
   Fragment BuildNullLiteral(TokenPosition* position);
+  Fragment BuildVectorCreation(TokenPosition* position);
+  Fragment BuildVectorGet(TokenPosition* position);
+  Fragment BuildVectorSet(TokenPosition* position);
+  Fragment BuildVectorCopy(TokenPosition* position);
+  Fragment BuildClosureCreation(TokenPosition* position);
 
   Fragment BuildInvalidStatement();
   Fragment BuildExpressionStatement();