extensions/browser/api/cast_channel/BUILD.gn - Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/BUILD.gn

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/BUILD.gn

diff --git a/extensions/browser/api/cast_channel/BUILD.gn b/extensions/browser/api/cast_channel/BUILD.gn

index 119ef06a5df35a61836139a104296ce13f937930..40ff859d26dad31b306dcd4d5a2ad54138aae802 100644

--- a/extensions/browser/api/cast_channel/BUILD.gn

+++ b/extensions/browser/api/cast_channel/BUILD.gn

@@ -14,6 +14,10 @@ source_set("cast_channel") {

"cast_message_util.h",

"cast_socket.cc",

"cast_socket.h",

+ "cast_socket_service.cc",

+ "cast_socket_service.h",

+ "cast_socket_service_factory.cc",

+ "cast_socket_service_factory.h",

"cast_transport.cc",

"cast_transport.h",

"keep_alive_delegate.cc",

« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/cast_channel/cast_channel_api.h » ('j') | no next file with comments »