Issue 2891023: Coverity: Fix missing const on RendererWebIDBIndexImpl overridden methods.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2891023: Coverity: Fix missing const on RendererWebIDBIndexImpl overridden methods. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by mattm

Modified:
4 years ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Coverity: Fix missing const on RendererWebIDBIndexImpl and RendererWebIDBDatabaseImpl methods. CID=9390,9389,9388,10844,10845,10846,10847 TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52516

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
M	chrome/renderer/renderer_webidbdatabase_impl.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/renderer_webidbdatabase_impl.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/renderer_webidbindex_impl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/renderer_webidbindex_impl.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Trybot results: linux mac

Total messages: 4 (0 generated)

mattm

Added RendererWebIDBDatabaseImpl fixes too, mind taking another look?

4 years, 10 months ago (2010-07-15 01:15:23 UTC) #3

LGTM