third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp - Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

index 9d085807f3fa92e5b0473cbdd21fe0edef48e5b2..f65d8c4885a474b681386f74dd96191fda92944f 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp

@@ -99,10 +99,10 @@ TEST_F(CompositorMutableStateTest, MutableStateMutableProperties) {

SetLayerPropertiesForTesting(layer);

- int primary_id = 12;

- root->SetElementId(CompositorElementIdFromDOMNodeId(

+ uint64_t primary_id = 12;

+ root->SetElementId(CompositorElementIdFromPaintLayerId(

primary_id, CompositorElementIdNamespace::kPrimary));

- layer->SetElementId(CompositorElementIdFromDOMNodeId(

+ layer->SetElementId(CompositorElementIdFromPaintLayerId(

primary_id, CompositorElementIdNamespace::kScroll));

root->SetMutableProperties(CompositorMutableProperty::kOpacity |