third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)

Patch Set: none Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CompositorAnimations.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 317da4943e75f44fa0f4f4e622d136ac0ae25b50..c16dca9680443fba42ed431e0913ec794cf008fe 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -356,13 +356,13 @@ static std::unique_ptr<WebScrollbarLayer> CreateScrollbarLayer(

scrollbar_layer =

Platform::Current()->CompositorSupport()->CreateOverlayScrollbarLayer(

WebScrollbarImpl::Create(&scrollbar), painter, std::move(geometry));

- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(

+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(

NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));

} else {

scrollbar_layer =

Platform::Current()->CompositorSupport()->CreateScrollbarLayer(

WebScrollbarImpl::Create(&scrollbar), painter, std::move(geometry));

- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(

+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(

NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));

}

GraphicsLayer::RegisterContentsLayer(scrollbar_layer->Layer());

@@ -382,7 +382,7 @@ ScrollingCoordinator::CreateSolidColorScrollbarLayer(

Platform::Current()->CompositorSupport()->CreateSolidColorScrollbarLayer(

web_orientation, thumb_thickness, track_start,

is_left_side_vertical_scrollbar);

- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(

+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(

NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));

GraphicsLayer::RegisterContentsLayer(scrollbar_layer->Layer());

return scrollbar_layer;