Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index d4eae053bf2e352d09c4bdb50a98d4244b85028a..f306160429505259b2acd7abbb7a6b1c00638bc0 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -356,13 +356,13 @@ static std::unique_ptr<WebScrollbarLayer> CreateScrollbarLayer(
scrollbar_layer =
Platform::Current()->CompositorSupport()->CreateOverlayScrollbarLayer(
WebScrollbarImpl::Create(&scrollbar), painter, std::move(geometry));
- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(
+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(
NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));
} else {
scrollbar_layer =
Platform::Current()->CompositorSupport()->CreateScrollbarLayer(
WebScrollbarImpl::Create(&scrollbar), painter, std::move(geometry));
- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(
+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(
NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));
}
GraphicsLayer::RegisterContentsLayer(scrollbar_layer->Layer());
@@ -382,7 +382,7 @@ ScrollingCoordinator::CreateSolidColorScrollbarLayer(
Platform::Current()->CompositorSupport()->CreateSolidColorScrollbarLayer(
web_orientation, thumb_thickness, track_start,
is_left_side_vertical_scrollbar);
- scrollbar_layer->SetElementId(CompositorElementIdFromDOMNodeId(
+ scrollbar_layer->SetElementId(CompositorElementIdFromScrollbarId(
NextScrollbarId(), CompositorElementIdNamespace::kScrollbar));
GraphicsLayer::RegisterContentsLayer(scrollbar_layer->Layer());
return scrollbar_layer;
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698