Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2890953002: [SPv1] Always set a CompositorElementId on main graphics layers; use PaintLayer id. (Closed)
Patch Set: none Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
index 0179f6125b962d1e985b8e32604043ca309fc759..7b2c1ea26302936149a29143f88714e313985ff6 100644
--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
@@ -446,15 +446,16 @@ void CompositorAnimations::AttachCompositedLayers(Element& element,
return;
if (!element.GetLayoutObject() ||
- !element.GetLayoutObject()->IsBoxModelObject())
+ !element.GetLayoutObject()->IsBoxModelObject() ||
+ !element.GetLayoutObject()->HasLayer())
return;
+ PaintLayer* layer =
+ ToLayoutBoxModelObject(element.GetLayoutObject())->Layer();
+
// Composited animations do not depend on a composited layer mapping for SPv2.
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- PaintLayer* layer =
- ToLayoutBoxModelObject(element.GetLayoutObject())->Layer();
-
- if (!layer || !layer->IsAllowedToQueryCompositingState() ||
+ if (!layer->IsAllowedToQueryCompositingState() ||
!layer->GetCompositedLayerMapping() ||
!layer->GetCompositedLayerMapping()->MainGraphicsLayer())
return;
@@ -466,8 +467,8 @@ void CompositorAnimations::AttachCompositedLayers(Element& element,
}
CompositorAnimationPlayer* compositor_player = animation.CompositorPlayer();
- compositor_player->AttachElement(CompositorElementIdFromDOMNodeId(
- DOMNodeIds::IdForNode(&element), CompositorElementIdNamespace::kPrimary));
+ compositor_player->AttachElement(CompositorElementIdFromPaintLayerId(
+ layer->UniqueId(), CompositorElementIdNamespace::kPrimary));
}
bool CompositorAnimations::ConvertTimingForCompositor(

Powered by Google App Engine
This is Rietveld 408576698