Use LibraryIndex in CoreTypes instead of extending it.

Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/77d4eb609b1df3e56e7792ea54bbc71e8eda04b3

[scheglov, 2017-05-17 20:48:22]

Description was changed from

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

[scheglov, 2017-05-17 20:48:22]

scheglov@google.com changed reviewers:
+ kmillikin@google.com

[scheglov, 2017-05-17 20:48:42]

Description was changed from

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, paulberry@google.com, sigmund@google.com, kmillikin@google.com
BUG=
==========

[Paul Berry, 2017-05-17 20:55:19]

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.dart
File pkg/kernel/lib/core_types.dart (right):

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.d...
pkg/kernel/lib/core_types.dart:109: Procedure get
asyncErrorWrapperHelperProcedure {
Personally I would prefer to see everything lazy or nothing lazy.  Right now it
seems like a historical accident which things are lazy and which things aren't.

But I'm curious to hear Peter and Kevin's opinions on this.

[ahe, 2017-05-22 09:30:03]

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.dart
File pkg/kernel/lib/core_types.dart (right):

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.d...
pkg/kernel/lib/core_types.dart:40: Library coreLibrary;
Please restore the original order.

[scheglov, 2017-05-22 19:04:00]

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.dart
File pkg/kernel/lib/core_types.dart (right):

https://codereview.chromium.org/2890933002/diff/1/pkg/kernel/lib/core_types.d...
pkg/kernel/lib/core_types.dart:40: Library coreLibrary;
On 2017/05/22 09:30:02, ahe wrote:
> Please restore the original order.

I'm sorry, but the original order of what?
Put the static member "requiredClasses" between instance fields and the
constructor?
The rest of the class is quite different, there isn't much to restore.

[scheglov, 2017-05-22 20:00:00]

PTAL

[Paul Berry, 2017-05-22 20:05:13]

lgtm, but I think we should wait for approval from Peter, Kevin, or Siggi before
landing.

[Siggi Cherem (dart-lang), 2017-05-23 16:00:35]

lgtm!

[scheglov, 2017-05-23 16:30:43]

Description was changed from

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, paulberry@google.com, sigmund@google.com, kmillikin@google.com
BUG=
==========

to

==========
Use LibraryIndex in CoreTypes instead of extending it.

A smaller step this time - change only clients, but keep implementation
the same for now.

Not all patched SDKs have all classes and procedures, so I have to make
some them lazy. All of them could be done for consistency, but this
might slightly affect performance for often used dart:core classes.

Also it's a bit of mess now.
Maybe group these classes into logical structures, coreTypes.core.list,
coreTypes.async.future, coreTypes.async.futureMicrotask, etc. Something
like it was before this change, but fixed types and names instead of
more flexible (but in general slower) strings.


R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/77d4eb609b1df3e56e7792ea54bbc71e8eda04b3
==========

[scheglov, 2017-05-23 16:30:44]

Committed patchset #3 (id:40001) manually as
77d4eb609b1df3e56e7792ea54bbc71e8eda04b3 (presubmit successful).