dart2js: --fast-startup: updateHolders always copies properties

dart2js: --fast-startup: updateHolders always copies properties

The 'trick' of splicing __proto__ builds long prototype chains, so don't do it.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9

[sra1, 2017-05-17 17:45:21]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-17 17:57:40]

lgtm

https://codereview.chromium.org/2890873002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2890873002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:77: var
isChrome = (typeof window != 'undefined') &&
I believe this was only used for updateHolders, maybe we can drop this
definition too?

[sra1, 2017-05-18 00:33:53]

https://codereview.chromium.org/2890873002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/2890873002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:77: var
isChrome = (typeof window != 'undefined') &&
On 2017/05/17 17:57:40, Siggi Cherem (dart-lang) wrote:
> I believe this was only used for updateHolders, maybe we can drop this
> definition too?

Done.

[sra1, 2017-05-18 00:45:56]

Description was changed from

==========
dart2js: --fast-startup: updateHolders always copies properties

The 'trick' of splicing __proto__ builds long prototype chains, so don't do it.
==========

to

==========
dart2js: --fast-startup: updateHolders always copies properties

The 'trick' of splicing __proto__ builds long prototype chains, so don't do it.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4af03b1a658675c8490e8c4c3721e6a2991c17e9
==========

[sra1, 2017-05-18 00:45:57]

Committed patchset #2 (id:20001) manually as
4af03b1a658675c8490e8c4c3721e6a2991c17e9 (presubmit successful).